stdlib: Fix compiler warnings in Concurrency, Cxx, and RuntimeModule#87424
Merged
Conversation
- Remove spurious `unsafe` on non-unsafe calls in TaskCancellation.swift and UnsafeCxxIterators.swift - Change `var fd` to `let fd` in ImageSource.swift since it is never mutated
tshortli
requested review from
Xazax-hun,
al45tair,
egorzhdan,
j-hui,
ktoso,
mikeash and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
28pins
approved these changes
Feb 23, 2026
Contributor
Author
|
swiftlang/swift-experimental-string-processing#854 @swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsafeon non-unsafe calls in TaskCancellation.swift and UnsafeCxxIterators.swiftvar fdtolet fdin ImageSource.swift since it is never mutated